Skip to content

remove legacy_const_generic_args cache #150098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Bryntet wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove legacy_const_generic_args cache #150098

Bryntet wants to merge 1 commit into from
+14 −18

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Dec 17, 2025

putting this here to run perf

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 17, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 17, 2025
@rust-bors
Auto merge of #150098 - Bryntet:perf-testing, r=<try>
092ee16 
remove `legacy_const_generic_args` cache
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 17, 2025
@rust-bors
Copy link

rust-bors bot commented Dec 17, 2025

☀️ Try build successful (CI)
Build commit: 092ee16 (092ee1665659883f4a18253cfb5366324ed37d82, parent: f2c70877a7dbc51cd98e2d5d25209b24d4a586d5)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 17, 2025

Finished benchmarking commit (092ee16): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.3%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.6% [1.9%, 3.8%] 3
Regressions ❌
(secondary)		 1.5% [0.7%, 2.2%] 2
Improvements ✅
(primary)		 -6.6% [-6.6%, -6.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.3% [-6.6%, 3.8%] 4

Cycles

Results (primary 2.1%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-2.7%, -2.4%] 2
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.372s -> 484.678s (0.27%)
Artifact size: 390.57 MiB -> 390.56 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bryntet @JonathanBrouwer @rust-timer @rustbot